-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples/iOS tv-casting-app: simplified discovery and connection APIs #31275
Merged
mergify
merged 1 commit into
project-chip:master
from
sharadb-amazon:ios-disccon-20240107
Jan 8, 2024
Merged
examples/iOS tv-casting-app: simplified discovery and connection APIs #31275
mergify
merged 1 commit into
project-chip:master
from
sharadb-amazon:ios-disccon-20240107
Jan 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mhazley and
mkardous-silabs
January 7, 2024 22:03
pullapprove
bot
requested review from
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
January 7, 2024 22:03
sharadb-amazon
force-pushed
the
ios-disccon-20240107
branch
from
January 7, 2024 22:06
13453ba
to
9d3b5f6
Compare
PR #31275: Size comparison from 7381d76 to 9d3b5f6 Decreases (1 build for efr32)
Full report (60 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
sharadb-amazon
force-pushed
the
ios-disccon-20240107
branch
2 times, most recently
from
January 8, 2024 00:50
ad16511
to
0b30140
Compare
sharadb-amazon
force-pushed
the
ios-disccon-20240107
branch
from
January 8, 2024 01:09
0b30140
to
dcb7ea6
Compare
PR #31275: Size comparison from 7381d76 to dcb7ea6 Increases above 0.2%:
Increases (1 build for linux)
Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
chrisdecenzo
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see comments
examples/tv-casting-app/tv-casting-common/support/ChipDeviceEventHandler.cpp
Show resolved
Hide resolved
hawk248
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change simplifies and decouples the implementation of the discovery and connection APIs for the iOS tv-casting-app from the old CastingServerBridge.h/mm.
Change summary
Testing
Verified and tested locally with Linux TV app